Unzip with iconv patch

A lot of Linux distributions has unzip with iconv patch, which will has a -I and -O options to allow us to set the charset for filenames. But why unzip in openSUSE has no such patch?

Because nobody has submitted it, I suspect. We also generally try to avoid patching upstream packages for functionality, as a general rule.

@JeromeCui openSUSE follows upstream, upstream many moons ago rejected the patch…

1 Like

Well, File unzip-iso8859_2.patch of Package unzip - openSUSE Build Service adds option -O for one off conversion of file names and this patch would conflict with iconv patch. But it is exactly “patching upstream for functionality”. Personally I would opt for generic conversion support instead of special casing one single encoding.

Upstream is dead for 15 years so it is rather feeble excuse. It is rather that someone needs to prepare this patch and convince maintainers to accept it.

This is in line with what I read about RPMs and other package formats/managers.
Apparently in RPM-land, maintainers are discouraged from adding their own patches whereas with other package formats/managers like DEB/dpkg it’s common practice.

I do hope someone could have this patch be merged into the main. When I receive some archives from Windows, filenames in Chinese all are unreadable. I have to download a deb package of unzip from Debian and replace the unzip binary manually.

@arvidjaar not feeble, just fact, as I indicated, it was a long time ago…

Hence why I said generally.

There are always edge cases, and that’s largely up to the Maintainer.

I have no idea why they’ve chosen not to include the iconv patches, as I don’t maintain the package, nor do I have any knowledge of how they came to that decision.

I have patched a few things I maintain, for the /usr/etc configuration location, for openSUSE, because upstream indicated that they weren’t interested in adding that as an option, but it’s “adding functionality” as a distribution patch, to fit in nicer in the openSUSE ecosystem.

So yes, it happens, at times. Standard practice, where possible, is to work with upstream, and get the patches accepted there, to reduce maintenance overhead at the distribution level.

You would need to contact the maintainers of unzip and make your case with them. The chances they’re monitoring the forums is pretty low.

more than 10 years has been passed since the last update to unzip. I think apply the patch in openSUSE package would be more likely to make it work. If the official package won’t apply the package, i hope someone could maintain a patched one in personal repository.

This topic was automatically closed 30 days after the last reply. New replies are no longer allowed.