submitting a patch for WindowMaker-applets.

For several years, I have been patching GrabImage locally. :frowning:
After building some (not all) of the applets for Fedora in my repo, I realized that I should probably submit the following patch for WindowMaker-applets in openSUSE.

--- wmGrabImage/GrabImage.orig  2011-07-21 03:20:18.000000000 -0700
+++ wmGrabImage/GrabImage       2011-07-21 03:21:00.000000000 -0700
@@ -58,6 +58,6 @@
     }
 
 
-    system "convert -geom 54x54 $home/.wmGrabImage/${ImageName} ${home}/.wmGrabImage/${ImageName}.tmp.xpm";
+    system "convert -geometry 54x54 $home/.wmGrabImage/${ImageName} ${home}/.wmGrabImage/${ImageName}.tmp.xpm";
     system "cat ${home}/.wmGrabImage/${ImageName}.tmp.xpm | sed -e \"s/Transparent/Black/\" \> ${home}/.wmGrabImage/${ImageName}.xpm; rm ${home}/.wmGrabImage/${ImageName}.tmp.xpm";

What’s the best way to do it?

Hi
Into Factory?


Cheers Malcolm °¿° (Linux Counter #276890)
openSUSE 11.4 (x86_64) Kernel 2.6.37.6-0.5-desktop
up 11 days 7:29, 4 users, load average: 0.04, 0.07, 0.05
GPU GeForce 8600 GTS Silent - Driver Version: 270.41.19

I didn’t install the factory version, but I understand that it does make sense to submit patches there.
OK, I just took a quick look at this version and it hasn’t still been fixed. So how do I submit this patch? Should I branch the package in my repo (and create a new project first), add my patch, compile it and then … send a request? (which I never did before). I’m asking because I don’t know. I haven’t work for very long in OBS. Until now, I just created my own repo to put missing packages or fix or customize other ones, as I thought it would be faster (I’m not sure it was). However it’s easier for me now to install and update these packages on openSUSE and Fedora (I still don’t know to use OBS repo in Mandriva - with urpmi - , AFAIK it’s not possible. But it’s another problem.)

Hi
You need to push the fix upstream as a bug then you can use in the
changes file as per the format;
http://en.opensuse.org/openSUSE:Packaging_Patches_guidelines

You need to see which development project it resides in (that links to
factory), else do you want to push the fix into 11.3 and 11.4 updates as
well?
http://en.opensuse.org/openSUSE:Build_Service_Concept_Maintenance


Cheers Malcolm °¿° (Linux Counter #276890)
openSUSE 11.4 (x86_64) Kernel 2.6.37.6-0.5-desktop
up 11 days 16:35, 5 users, load average: 0.15, 0.17, 0.14
GPU GeForce 8600 GTS Silent - Driver Version: 270.41.19

I asked my wife to submit a bug report (because I’m not very good at that). The patch is attached in the bug report.

https://bugzilla.novell.com/show_bug.cgi?id=707539

Hi
Also report it to the windowmaker developers as a bug and reference the
bugzilla one. When I said upstream I meant the windowmaker folks :wink:

Then reference the windowmaker bug in the bugzilla and then assign the
bug to yourself.

Now do you want to fix in openSUSE 11.3 and 11.4? If so then use the
maintenance routine to update.


Cheers Malcolm °¿° (Linux Counter #276890)
openSUSE 11.4 (x86_64) Kernel 2.6.37.6-0.5-desktop
up 11 days 19:52, 5 users, load average: 0.08, 0.16, 0.15
GPU GeForce 8600 GTS Silent - Driver Version: 270.41.19

The WindowMaker-applets package in openSUSE is a collection of applets written by different people. I don’t think that windowmaker developpers have influence on that (but I don’t know). Many of these applets are not developed any more. Have to check for wmgrabimage.

Well, the idea is to fix the bug before installing the package rather than having to patch the buggy script afterwards. I could fix it by branching the package and add the patch. Is that what I’m supposed to do? And is that not actually how you did when you fixed my bugs in two other wm applets and send me a request? I was wondering if you could do the same with the standard repo, but probably not.

Hi
You should see if there is a place upstream to log a bug…

So where did the package originate from in OBS?

If the package is used in 11.3 and 11.4 release, then you would push an
update out to everyone via the maintenance routine, plus taking
ownership of the bug.

If it’s just sitting in a contrib repo then just branch and update.

You could also just let the bug takes it’s course and the openSUSE
maintainer will add the patch etc, I would wait a few days and see what
happens to the bug first.


Cheers Malcolm °¿° (Linux Counter #276890)
openSUSE 11.4 (x86_64) Kernel 2.6.37.6-0.5-desktop
up 11 days 22:41, 5 users, load average: 0.13, 0.11, 0.07
GPU GeForce 8600 GTS Silent - Driver Version: 270.41.19

It’s in standard. I noticed that the link I provided in my first post was bad, sorry.

https://build.opensuse.org/package/show?package=WindowMaker-applets&project=openSUSE%3A11.4

So this is not the same. It answers my question.

Sounds reasonable.