Another 64bit-portability-issue

English Open Build Service (OBS)
1

Hi
Build gnotime and have struck this issue in the build checks;


E: gnotime 64bit-portability-issue notes-area.c:423

In the build log is the following;


notes-area.c: In function 'projects_tree_clicked':
notes-area.c:423: warning: implicit declaration of function
'menus_get_popup'
notes-area.c:423: warning: assignment makes pointer
from integer without a cast
notes-area.c:415: warning: unused variable
'projects_tree'

This is the area of code, ‘static init’ is line 411


static int
projects_tree_clicked (GtkWidget *ptree, GdkEvent *event, gpointer data)
{
GdkEventButton *bevent = (GdkEventButton *) event;
GttProjectsTree *projects_tree = GTT_PROJECTS_TREE (ptree);
GtkMenuShell *menu;

if (!(event->type == GDK_BUTTON_PRESS && bevent->button == 3))
{
return FALSE;
}

menu = menus_get_popup ();
gtk_menu_popup (GTK_MENU (menu), NULL, NULL, NULL, NULL, 3,
bevent->time);

return FALSE;

}

Anyone have a thought as to how to proceed? syampillai?

–
Cheers Malcolm °¿° (Linux Counter #276890)
SUSE Linux Enterprise Desktop 11 (x86_64) Kernel 2.6.27.45-0.1-default
up 2 days 2:51, 4 users, load average: 0.11, 0.11, 0.09
GPU GeForce 8600 GTS Silent - CUDA Driver Version: 190.53

2

That usually means that there is no prototype for menus_get_popup() which presumably should be declared to return a GtkMenuShell *. Was an include file missed?

3

Hi Ken
The only thing they appear to have done is add the reference to
project-tree.h and associated code in the notes-area.c and notes-area.h
files


gnotime-2.3.0/src$ fgrep GtkMenuShell *

active-dialog.c:	GtkMenuShell *menushell;
menus.c:GtkMenuShell *
menus.c:	static GtkMenuShell *menu = NULL;
menus.c:	menu = (GtkMenuShell *)gtk_menu_new();
menus.h:GtkMenuShell *menus_get_popup(void);
notes-area.c:	GtkMenuShell *menu;

gnotime-2.3.0/src$ fgrep menus_get_popup *

menus.c:menus_get_popup(void)
menus.c:	menus_get_popup(); /* initialize it */
menus.h:GtkMenuShell *menus_get_popup(void);
notes-area.c:	menu = menus_get_popup ();

<scratching head>

–
Cheers Malcolm °¿° (Linux Counter #276890)
SUSE Linux Enterprise Desktop 11 (x86_64) Kernel 2.6.27.45-0.1-default
up 2 days 10:48, 5 users, load average: 0.04, 0.08, 0.08
GPU GeForce 8600 GTS Silent - CUDA Driver Version: 190.53

4

So is menus.h directly or indirectly included by notes-area.c?

5

Hi Ken
Added an includes patch and that got rid of the error on line 423, will
see how it goes now on the build service :slight_smile: :slight_smile:

Is that because menus.* showed up in the fgrep output?

–
Cheers Malcolm °¿° (Linux Counter #276890)
SUSE Linux Enterprise Desktop 11 (x86_64) Kernel 2.6.27.45-0.1-default
up 2 days 12:50, 5 users, load average: 1.06, 0.49, 0.79
GPU GeForce 8600 GTS Silent - CUDA Driver Version: 190.53

6

Without the inclusion of menu.h (menus_get_popup is defined in that file), it assumes that menus_get_popup returns an int (this is the default assumption! No definition found for a function means - returns “int”!)

7

Hi
Many thanks you two :slight_smile: It’s building ok, just fighting with gconf
now… different releases have different locations and my standard
burb for it doesn’t seem to be working…grrrr

–
Cheers Malcolm °¿° (Linux Counter #276890)
SUSE Linux Enterprise Desktop 11 (x86_64) Kernel 2.6.27.45-0.1-default
up 2 days 18:41, 4 users, load average: 0.48, 0.45, 0.33
GPU GeForce 8600 GTS Silent - CUDA Driver Version: 190.53