Page 2 of 2 FirstFirst 12
Results 11 to 19 of 19

Thread: How to patch?

  1. #11

    Default Re: How to patch?

    The same source. And I very often face it: the same source but for later SUSE version the patch fails.

  2. #12

    Default Re: How to patch?

    I have just changed the spec to use %patch script. Now for 11.2 builds, for 11.3 fails:
    https://build.opensuse.org/package/s...3AAnsus%3AKDE3

  3. #13

    Default Re: How to patch?

    Quote Originally Posted by Ansus View Post
    I have just changed the spec to use %patch script. Now for 11.2 builds, for 11.3 fails:
    https://build.opensuse.org/package/s...3AAnsus%3AKDE3
    That's because newer RPMs run patch with a lower fuzz level. Just fix the patch (I still recommend quilt for such tasks).

  4. #14

    Default Re: How to patch?

    Quote Originally Posted by RedDwarf View Post
    That's because newer RPMs run patch with a lower fuzz level. Just fix the patch (I still recommend quilt for such tasks).
    So it is like a lottery - will your patch work or not.

  5. #15
    Join Date
    Jun 2008
    Location
    Moscow, Russia
    Posts
    3,001
    Blog Entries
    1

    Default Re: How to patch?

    As RedDwarf said, quilt is the best tool. It can refresh the patch to fuzz=0.

  6. #16

    Default Re: How to patch?

    Quote Originally Posted by Ansus View Post
    So it is like a lottery - will your patch work or not.
    The patch is wrong, that's the only problem and not related to lottery.
    In openSUSE < 11.3 the patch works because RPM is making you a favor and accepting that patch even knowing it has problems. But to make you that favor patch has to make some guesses and sometimes ends applying the patch in the wrong position. After years of problems because packagers didn't noticed those guessing problems it was decided that RPM should stop making favors... if a patch needs to be updated the packager must manually update it verifying everything is ok.

    The only lottery is knowing if patch is applying that patch correctly in the openSUSE versions that "works".

  7. #17

    Default Re: How to patch?

    The patch is wrong, that's the only problem and not related to lottery.
    Why is it wrong?

  8. #18

    Default Re: How to patch?

    Quote Originally Posted by Ansus View Post
    Why is it wrong?
    A patch says "this is what there is now, it must be changed by this other thing". And your patch is wrong in the "this is what there is now". The patch program looks at the file to be patched, looks at the patch file... and sees they don't match.

    It is like if I say you to repaint the green wall in red... and all walls are yellow.

    Your are trying to apply a patch for kalgebra 0.4 to kalgreba 0.5... it just doesnt works. Recreate the patch for kalgebra 0.5 and everything will work just fine.

  9. #19
    Join Date
    Jun 2008
    Location
    Podunk
    Posts
    26,650
    Blog Entries
    15

    Default Re: How to patch?

    Quote Originally Posted by RedDwarf
    Ansus;2225523 Wrote:
    > Why is it wrong?

    A patch says "this is what there is now, it must be changed by this
    other thing". And your patch is wrong in the "this is what there is
    now". The patch program looks at the file to be patched, looks at the
    patch file... and sees they don't match.

    It is like if I say you to repaint the green wall in red... and all
    walls are yellow.

    Your are trying to apply a patch for kalgebra 0.4 to kalgreba 0.5... it
    just doesnt works. Recreate the patch for kalgebra 0.5 and everything
    will work just fine.

    Also if the patch has been pushed upstream the new version may already
    include the patch. As a packager you need to look at the patch and
    check the code to see what has changed, there may be more lines of
    code, but the patch is still needed.

    --
    Cheers Malcolm (Linux Counter #276890)
    SUSE Linux Enterprise Desktop 11 (x86_64) Kernel 2.6.32.19-0.2-default
    up 4 days 4:37, 2 users, load average: 0.08, 0.07, 0.09
    GPU GeForce 8600 GTS Silent - Driver Version: 256.53


Page 2 of 2 FirstFirst 12

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •